Re: [sqlsmith] Infinite recursion in bitshift - Mailing list pgsql-hackers

From Andreas Seltenreich
Subject Re: [sqlsmith] Infinite recursion in bitshift
Date
Msg-id 877f9azpv1.fsf@credativ.de
Whole thread Raw
In response to Re: [sqlsmith] Infinite recursion in bitshift  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [sqlsmith] Infinite recursion in bitshift  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane writes:

>> This is due to an integer overflow in bitshiftright()/bitshiftleft()
>> leading to them recursively calling each other.  Patch attached.
>
> Seems sane, though I wonder if it'd be better to use -INT_MAX rather
> than -VARBITMAXLEN.

I am undecided between those two.  -INT_MAX might be a more precise fix
for the problem, but the extra distance to the danger zone was kind of
soothing :-).

regards,
Andreas



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [sqlsmith] Infinite recursion in bitshift
Next
From: Tom Lane
Date:
Subject: Re: [sqlsmith] Infinite recursion in bitshift