Re: pg_dump exclusion switches and functions/types - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: pg_dump exclusion switches and functions/types
Date
Msg-id 874pug6ere.fsf@enterprisedb.com
Whole thread Raw
In response to Re: pg_dump exclusion switches and functions/types  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_dump exclusion switches and functions/types  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pg_dump exclusion switches and functions/types  (David Fetter <david@fetter.org>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> The existing patch's behavior is that "the rightmost switch wins", ie, if an
> object's name matches more than one pattern then it is included or excluded
> according to the rightmost switch it matches. This is, erm, poorly
> documented, but it seems like useful behavior so I don't have an objection
> myself.

I don't know, it sounds like it's the source of the confusion you identify
later.

My first thought is that the rule should be to apply all the inclusion
switches (implicitly including everything if there are none), then apply all
the exclusion switches.

That leads to including non-schema objects only if there are no schema
inclusion switches. Which seems pretty logical since if you're explicitly
including objects then you'll only expect objects explicitly included to be
dumped and you'll quickly realize there's no switch to bring in those
non-schema objects. Maybe there should be a switch to include them just for
completeness.

--  Gregory Stark EnterpriseDB          http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: pg_upgrade: downgradebility
Next
From: Bruce Momjian
Date:
Subject: Added links to the release notes