Postgres Pro
Downloads
Home   >   mailing lists

Re: [sqlsmith] Crash in GetOldestSnapshot() - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: [sqlsmith] Crash in GetOldestSnapshot()
Date
Msg-id 874m6ydrna.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to [sqlsmith] Crash in GetOldestSnapshot()  (Andreas Seltenreich <seltenreich@gmx.de>)
Responses Re: [sqlsmith] Crash in GetOldestSnapshot()  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
>>>>> "Andreas" == Andreas Seltenreich <seltenreich@gmx.de> writes:

418   if (OldestActiveSnapshot != NULL)
419       ActiveLSN = OldestActiveSnapshot->as_snap->lsn;
420
421   if (XLogRecPtrIsInvalid(RegisteredLSN) || RegisteredLSN > ActiveLSN)
422       return OldestActiveSnapshot->as_snap;

This second conditional should clearly be inside the first one...

-- 
Andrew (irc:RhodiumToad)

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [sqlsmith] Crash in GetOldestSnapshot()
Next
From: Amit Kapila
Date:
Subject: Re: [sqlsmith] Crash in GetOldestSnapshot()