Re: CREATE MATERIALIZED VIEW - Mailing list pgsql-hackers

From Dagfinn Ilmari Mannsåker
Subject Re: CREATE MATERIALIZED VIEW
Date
Msg-id 874j8deccy.fsf@wibble.ilmari.org
Whole thread Raw
In response to Re: CREATE MATERIALIZED VIEW  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: CREATE MATERIALIZED VIEW
List pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:

> On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> However, since it looks like the feature was never actually supported in a
>>> release, and the revert has been in place for over a decade, I think it'd
>>> be reasonable to remove the tab completion now.  It looks like the folks on
>>> the 2021 thread felt similarly.
>> 
>> Keeping it in the grammar makes sense for the more specific error
>> message, but I don't think the tab completion should be suggesting bogus
>> things, regardless of whether it's the grammar or the parse analysis
>> that rejects it.
>
> Would you mind creating a commitfest entry for this one?  I'll plan on
> committing this early next week unless any objections materialize.

Done: https://commitfest.postgresql.org/49/5139/

I've taken the liberty of setting you as the committer, and the target
version to 17 even though it turns out to be an older bug, since it's
arguably a follow-on fix to the incomplete fix in c951e9042dd1.

- ilmari



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: CREATE MATERIALIZED VIEW
Next
From: Nathan Bossart
Date:
Subject: Re: [PATCH] Add crc32(text) & crc32(bytea)