Re: Another extensions bug - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: Another extensions bug
Date
Msg-id 8739gruu5v.fsf@hi-media-techno.com
Whole thread Raw
In response to Re: Another extensions bug  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Another extensions bug
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:
> On further reflection, it seems more in keeping with the coding
> elsewhere in this module to treat this as a distinct dependency type,
> instead of confusing it with a NORMAL dependency.  There's no actual
> functional difference at the moment, but more info is better than less.

Seems better indeed.  In my first implementation, we had no EXTENSION
kind of dependency and used only INTERNAL, which IIRC reads reverse than
the other ones.  Having to finally have EXTENSION and REVERSE kinds of
dependencies here is not that surprising.

> Hence, proposed patch attached (which also improves some of the related
> comments).

+1 on the idea, although I'm not in a position to further review or play
with the patch today.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Another extensions bug
Next
From: Markus Wanner
Date:
Subject: Re: cheaper snapshots redux