Request a Demo
Home   >   mailing lists

Re: Broken build on macOS (Universal / Intel): cpuid instruction not available - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Broken build on macOS (Universal / Intel): cpuid instruction not available
Date
Msg-id 873909.1778170924@sss.pgh.pa.us
Whole thread
In response to Re: Broken build on macOS (Universal / Intel): cpuid instruction not available  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Broken build on macOS (Universal / Intel): cpuid instruction not available
List pgsql-hackers
Tree view 
I wrote:
> ... The code in HEAD doesn't have
> that guard, and is essentially assuming that every x86 platform
> wil provide HAVE__GET_CPUID or HAVE__CPUID.

Independently of whether macOS multi-arch is something we consider
supportable, I think the aforesaid assumption is a bad idea.
Can't we make pg_cpuid() return zeroes if it doesn't know how to
get the info, analogously to what pg_cpuid_subleaf() does?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Fix bug with accessing to temporary tables of other sessions
Next
From: Masahiko Sawada
Date:
Subject: Re: Fix race condition in XLogLogicalInfo and ProcSignal initialization.