Postgres Pro
Downloads
Home   >   mailing lists

Re: 0x1A in control file on Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 0x1A in control file on Windows
Date
Msg-id 8735.1221713314@sss.pgh.pa.us
Whole thread Raw
In response to 0x1A in control file on Windows  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: 0x1A in control file on Windows  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Re: 0x1A in control file on Windows  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tree view 
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> I found a bug that pg_controldata ends with error if control files
> contain 0x1A (Ctrl+Z) on Windows.

> We probably need to add PG_BINARY when we open control files
> because 0x1A is an end-of-file marker on Windows.

Well, why is that a bug?  If the platform is so silly as to define text
files that way, who are we to argue?
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: optimizing CleanupTempFiles
Next
From: Heikki Linnakangas
Date:
Subject: Re: optimizing CleanupTempFiles