Postgres Pro
Downloads
Home   >   mailing lists

Re: max_slot_wal_keep_size and wal_keep_segments - Mailing list pgsql-hackers

From David Steele
Subject Re: max_slot_wal_keep_size and wal_keep_segments
Date
Msg-id 87269252-772e-2daf-9955-674a24e24de6@pgmasters.net
Whole thread Raw
In response to Re: max_slot_wal_keep_size and wal_keep_segments  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: max_slot_wal_keep_size and wal_keep_segments
List pgsql-hackers
Tree view 
On 7/14/20 12:00 AM, Fujii Masao wrote:
> 
> The patch was no longer applied cleanly because of recent commit.
> So I updated the patch. Attached.
> 
> Barring any objection, I will commit this patch.

This doesn't look right:

+   the <xref linkend="guc-wal-keep-size"/> most recent megabytes
+   WAL files plus one WAL file are

How about:

+   <xref linkend="guc-wal-keep-size"/> megabytes of
+   WAL files plus one WAL file are

Other than that, looks good to me.

Regards,
-- 
-David
david@pgmasters.net

pgsql-hackers by date:

Previous
From: "osumi.takamichi@fujitsu.com"
Date:
Subject: RE: problem with RETURNING and update row movement
Next
From: Robert Haas
Date:
Subject: Re: recovering from "found xmin ... from before relfrozenxid ..."