Re: Bug fix for glibc broke freebsd build in REL_11_STABLE - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
Date
Msg-id 871sa8vmg0.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: Bug fix for glibc broke freebsd build in REL_11_STABLE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> I kinda wonder if we should add -mno-x87 or such in configure when
 >> we detect clang, obviously it doesn't deal correctly with this.

 Tom> Seems worth looking into, but what happens if someone tries to
 Tom> compile for x87 hardware? Or do we care anymore?

Already discussed this one on IRC with Andres, but to put this on record
for future reference: we can't use -mno-x87 on 32bit intel, even with an
-march= option with an SSE2 capable CPU, because the 32-bit ABI requires
floats to be returned in the x87 registers and breaking that either
results in silently wrong results or in clang dying with "fatal error:
error in backend: X87 register return with X87 disabled" or similar.

-- 
Andrew (irc:RhodiumToad)


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: pointless check in RelationBuildPartitionDesc
Next
From: Andres Freund
Date:
Subject: Re: Bug fix for glibc broke freebsd build in REL_11_STABLE