Re: pgsql: Extend cube on-disk format to pack points more tightly. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Extend cube on-disk format to pack points more tightly.
Date
Msg-id 8711.1382424352@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Extend cube on-disk format to pack points more tightly.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
List pgsql-committers
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> This patch deliberately doesn't update all the alternative expected output
> files, as I don't have access to machines that produce those outputs. I'm
> not sure if they are still relevant, but if they are, the buildfarm will
> tell us and produce the diff required to fix it. If none of the buildfarm
> animals need them, they should be removed altogether.

dugong, for one, doesn't like this patch.

My usual habit for fixing alternative expected files is to apply the same
diff to those files as I got for the one my machine produces.  While this
occasionally doesn't work (when there are changes in the unportable
results as well as the portable ones), it works 90% of the time, whereas
your approach here works zero percent of the time.

            regards, tom lane


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Adjust cube.out expected output for new test queries.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Make use of psprintf() in recent changes