Re: [PATCH v1] Fix pg_basebackup long-path test on Windows - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH v1] Fix pg_basebackup long-path test on Windows
Date
Msg-id 867AF66D-DE6A-4100-9042-5604BB6CB09A@yesql.se
Whole thread
List pgsql-hackers
> On 26 Jul 2026, at 02:02, Harrison Booth <harrisontbooth@gmail.com> wrote:

> On my build, that target path was 253 characters.  Perl's mkdir failed
> at Windows' default 248-character directory path limit, but the result
> was unchecked.  The test then failed later with a misleading
> CREATE TABLESPACE "directory does not exist" error.

-mkdir "$tempdir/$superlongname";
+mkdir "$real_sys_tempdir/$superlongname"
+  or BAIL_OUT "could not create $real_sys_tempdir/$superlongname";

Shouldn't this include $! to give a hint to the user what the error might be?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: A new C function `get_partition_root`.
Next
From: Sami Imseih
Date:
Subject: Re: Add pg_stat_kind_info system view