Re: Allow specifying a dbname in pg_basebackup connection string - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Allow specifying a dbname in pg_basebackup connection string
Date
Msg-id 86622C5F-DDA5-46D8-B4CD-99429FA8CA35@yesql.se
Whole thread Raw
In response to Re: Allow specifying a dbname in pg_basebackup connection string  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Allow specifying a dbname in pg_basebackup connection string
List pgsql-hackers
> On 4 Nov 2024, at 18:14, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> perhaps under the illusion that dbname and connection_string can't
> both be NULL.

Ugh, yes, I failed to capture that nuance.

> I think the attached will fix it, but I wonder if there are edge
> cases I'm not thinking of.

+1 on your patch, reading through I can't see anything it misses.  Maybe a
comment above the change with a note on why dbname is tested for NULL there
would be good?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: New "raw" COPY format
Next
From: Daniel Gustafsson
Date:
Subject: Re: pg_dump --no-comments confusion