Re: Regression with large XML data input - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Regression with large XML data input
Date
Msg-id 865404.1753791071@sss.pgh.pa.us
Whole thread Raw
In response to Re: Regression with large XML data input  (Jim Jones <jim.jones@uni-muenster.de>)
Responses Re: Regression with large XML data input
List pgsql-hackers
Jim Jones <jim.jones@uni-muenster.de> writes:
> Out of curiosity, what's the reasoning behind keeping node_list instead
> of directly using parsed_nodes in the xmlParseBalancedChunkMemory call?

In the original coding, there was a hazard of the node list getting
leaked if the caller passed parsed_nodes == NULL.  Or at least I
thought there was.  It may be that all releases of libxml2 are smart
enough to free the node list if there's no way to pass it back,
but I guess we had reason not to trust it.  Possibly there's something
about that in the discussion that led up to 6082b3d5d, though I see
I neglected to mention it in the commit message.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Yura Sokolov
Date:
Subject: page_collect_tuples without long lock on page (Was Re: IPC/MultixactCreation on the Standby server)
Next
From: Daniel Gustafsson
Date:
Subject: Re: encode/decode support for base64url