location reporting in TAP test failures - Mailing list pgsql-hackers

From Peter Eisentraut
Subject location reporting in TAP test failures
Date
Msg-id 85dc0a81-0f35-272f-2126-be2253fa0898@2ndquadrant.com
Whole thread Raw
Responses Re: location reporting in TAP test failures
List pgsql-hackers
Right now, when a TAP test reports a failure, it looks something like this:

 #   Failed test 'creating a replication slot'
 #   at
/....../postgresql/src/bin/pg_basebackup/../../../src/test/perl/TestLib.pm
line 371.

That file location is where we call out to the test function provided by
Test::More.

What we'd really want is

 #   Failed test 'creating a replication slot'
 #   at t/020_pg_receivewal.pl line 36.

because that's where the code that's doing the testing is.

To achieve that, we need to have our test library functions tell that
they are support functions and not the actual tests.  The attached patch
does that.  The mechanism is (somewhat) explained in the Test::Builder
man page.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: commitfest 2018-07
Next
From: Pavel Stehule
Date:
Subject: Re: why partition pruning doesn't work?