Re: I: About "Our CLUSTER implementation is pessimal" patch - Mailing list pgsql-hackers

From Leonardo Francalanci
Subject Re: I: About "Our CLUSTER implementation is pessimal" patch
Date
Msg-id 857298.35297.qm@web29012.mail.ird.yahoo.com
Whole thread Raw
In response to Re: I: About "Our CLUSTER implementation is pessimal" patch  (Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: I: About "Our CLUSTER implementation is pessimal" patch
List pgsql-hackers
> I think writetup_rawheap() and readtup_rawheap() are a little  complex,
> but should work as long as there are no padding between t_len and  t_self
> in HeapTupleData struct.
>
> - It might be cleaner if you write the  total item length
>   and tuple data separately.
> - "(char *) tuple +  sizeof(tuplen)" might be more robust
>   than  "&tuple->t_self".


- I used your functions
- changed the docs for CLUSTER (I don't know if they make sense/are enough)
- added a minor comment


2 questions:

1) about the "copy&paste from FormIndexDatum" comment: how can I improve it?
The idea is that we could have a faster call, but it would mean copying and
pasting a lot of code from FormIndexDatum.

2) what other areas can I comment more?



Attachment

pgsql-hackers by date:

Previous
From: Yeb Havinga
Date:
Subject: Preliminary review of Synchronous Replication patches
Next
From: Peter Eisentraut
Date:
Subject: Re: Explicit psqlrc