Re: pgsql: Remove inappropriate memory context switch in - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove inappropriate memory context switch in
Date
Msg-id 8519.1228079358@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove inappropriate memory context switch in  ("Neil Conway" <neilc@samurai.com>)
Responses Re: pgsql: Remove inappropriate memory context switch in  ("Neil Conway" <neilc@samurai.com>)
List pgsql-committers
"Neil Conway" <neilc@samurai.com> writes:
> On Sun, Nov 30, 2008 at 10:49 AM, Tom Lane <tgl@postgresql.org> wrote:
>> Remove inappropriate memory context switch in shutdown_MultiFuncCall().

> I added that context switch for a reason:
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00153.php

Hm, too bad you didn't respond to my message inquiring about this a
couple days ago.

> Presumably that's why the build farm is crashing on dblink.

I'll take a look in a bit.  However, the switch in the shutdown function
was simply wrong, because it was *not* "returning to the caller's
context".  I suspect what this really says is dblink is doing something
it shouldn't.

            regards, tom lane

pgsql-committers by date:

Previous
From: "Neil Conway"
Date:
Subject: Re: pgsql: Remove inappropriate memory context switch in
Next
From: "Neil Conway"
Date:
Subject: Re: pgsql: Remove inappropriate memory context switch in