On 19.04.26 20:07, Paul A Jungwirth wrote:
> On Thu, Apr 16, 2026 at 8:20 PM jian he <jian.universality@gmail.com> wrote:
>>
>> On Thu, Apr 16, 2026 at 6:40 AM Paul A Jungwirth
>> <pj@illuminatedcomputing.com> wrote:
>>>
>>> I only have two small suggestions:
>>>
>>> Please use '[1, 11)' syntax to match the other tests.
>>>
>>> Breaking these long lines would be nice. For example:
>>>
>>> +CREATE RULE fpo_rule1 AS ON INSERT TO fpo_rule
>>> + DO INSTEAD UPDATE fpo_rule FOR PORTION OF f2 FROM 1 TO 4 SET f1 = 2;
>>>
>> Please check the attached v2.
>>
>> V1 only has DO INSTEAD rules, adding one DO ALSO rule would make the
>> test coverage more robust.
>
> Thanks for those changes. This looks great to me!
committed