Wrong comment in tuptable.h - Mailing list pgsql-hackers

From Jeff Davis
Subject Wrong comment in tuptable.h
Date
Msg-id 84af28311995d6b3f584b254bff7e8664124d7c1.camel@j-davis.com
Whole thread Raw
Responses Re: Wrong comment in tuptable.h
List pgsql-hackers

  /*
   * Return a copy of heap tuple representing the contents of the slot.
The
   * copy needs to be palloc'd in the current memory context. The slot
   * itself is expected to remain unaffected. It is *not* expected to
have
   * meaningful "system columns" in the copy. The copy is not be
"owned" by
   * the slot i.e. the caller has to take responsibility to free memory
   * consumed by the slot.
   */
  HeapTuple (*copy_heap_tuple) (TupleTableSlot *slot);

But acquire_sample_rows() calls ExecCopySlotHeapTuple(), and then
subsequently sorts the rows by TID. Is acquire_sample_rows() doing
something it shouldn't, or is the comment mistaken?

Regards,
    Jeff Davis





pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: SQL/JSON: JSON_TABLE
Next
From: Andres Freund
Date:
Subject: Re: Wrong comment in tuptable.h