Re: 4 pgcrypto regressions failures - 1 unsolved - Mailing list pgsql-hackers

From Tom Lane
Subject Re: 4 pgcrypto regressions failures - 1 unsolved
Date
Msg-id 8429.1121092766@sss.pgh.pa.us
Whole thread Raw
In response to Re: 4 pgcrypto regressions failures - 1 unsolved  (Marko Kreen <marko@l-t.ee>)
Responses Re: 4 pgcrypto regressions failures - 1 unsolved
List pgsql-hackers
Marko Kreen <marko@l-t.ee> writes:
> On Mon, Jul 11, 2005 at 10:10:12AM -0400, Tom Lane wrote:
>> The following addition to the patch shuts up gcc with openssl 0.9.7a,
>> but I'm not sure if it will break anything with older openssl ---
>> comments?

> They won't matter on older OpenSSL, as the macros will recast
> again.  But on 0.9.7e the signature is:

> void DES_ecb3_encrypt(const unsigned char *input, unsigned char *output,
>               DES_key_schedule *ks1,DES_key_schedule *ks2,
>               DES_key_schedule *ks3, int enc);

> so it seems to me that with your patch the warnings will appear
> on newer OpenSSL.  (Confirmed)

Grumble --- you're right.  It's probably not worth ifdef'ing the code to
suppress the warnings on 0.9.7a ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: 4 pgcrypto regressions failures - 1 unsolved
Next
From: Tom Lane
Date:
Subject: Re: 4 pgcrypto regressions failures - 1 unsolved