Re: More const-marking cleanup - Mailing list pgsql-hackers

From Tom Lane
Subject Re: More const-marking cleanup
Date
Msg-id 841907.1766544475@sss.pgh.pa.us
Whole thread Raw
In response to Re: More const-marking cleanup  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> I had another look and it seems to me that the one (src/port/getopt.c) reported
> and fixed in the attached of the previous email is the only remaining one to fix.

This fell off my radar for a bit, but pushed now.  Thanks for
catching it.

This does raise a question in my mind though: we did not find this
case the first time around because machines that have new-enough
compilers to detect such issues will probably not need our version of
getopt().  So, what other not-always-compiled bits of code could use
improvement, and how could we find them without undue effort?  (This
extends to more issues than just casting-away-const of course.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Fix incorrect buffer lock description in pg_visibility comment
Next
From: jian he
Date:
Subject: Re: let ALTER COLUMN SET DATA TYPE cope with POLICY dependency