Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2026-Apr-06, vignesh C wrote:
> > 2) Do you think it will be good to add a test to simulate a case where
> > one of the swap_replation_files is successful and a failure after
> > that. We can verify that the oid should still point to old oids:
>
> Hmm, it's not clear to me in which cases this can happen. Are you
> thinking that the first swap_replation_files call dies because of
> out-of-memory?
>
> Note that the really weird cases, like pg_class or mapped relations, are
> directly rejected. So we don't get into the branch with
> !RelFileNumberIsValid, and so on.
>
> I mean -- I'm not opposed to adding a test case for it. But I suspect
> it's going to be somewhat annoying to write.
After all, I think we'd end up testing whether transaction abort works
correctly.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
