Re: fd.c doesn't remove files on a crash-restart - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fd.c doesn't remove files on a crash-restart
Date
Msg-id 8367.1458151513@sss.pgh.pa.us
Whole thread Raw
In response to fd.c doesn't remove files on a crash-restart  ("Joshua D. Drake" <jd@commandprompt.com>)
Responses Re: fd.c doesn't remove files on a crash-restart
Re: fd.c doesn't remove files on a crash-restart
List pgsql-hackers
"Joshua D. Drake" <jd@commandprompt.com> writes:
> Hello,
> fd.c[1] will remove files from pgsql_tmp on a restart but not a 
> crash-restart per this comment:

> /*
> * NOTE: we could, but don't, call this during a post-backend-crash restart
> * cycle.  The argument for not doing it is that someone might want to 
> examine
> * the temp files for debugging purposes.  This does however mean that
> * OpenTemporaryFile had better allow for collision with an existing temp
> * file name.
> */

> I understand that this is designed this way. I think it is a bad idea 
> because:

Possible compromise: remove files only in non-Assert builds?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: fd.c doesn't remove files on a crash-restart
Next
From: Julien Rouhaud
Date:
Subject: Re: Choosing parallel_degree