Re: Catching resource leaks during WAL replay - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Catching resource leaks during WAL replay
Date
Msg-id 8316.1364425285@sss.pgh.pa.us
Whole thread Raw
In response to Re: Catching resource leaks during WAL replay  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Catching resource leaks during WAL replay  (Simon Riggs <simon@2ndQuadrant.com>)
Re: Catching resource leaks during WAL replay  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> On 27 March 2013 20:40, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
>> While looking at bug #7969, it occurred to me that it would be nice if we
>> could catch resource leaks in WAL redo routines better. It would be useful
>> during development, to catch bugs earlier, and it could've turned that
>> replay-stopping error into a warning.

> I'm inclined to think that the overhead isn't worth the trouble. This
> is the only bug of its type we had in recent years.

I agree that checking for resource leaks after each WAL record seems
too expensive compared to what we'd get for it.  But perhaps it's worth
making a check every so often, like at restartpoints?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)
Next
From: Simon Riggs
Date:
Subject: Re: Catching resource leaks during WAL replay