Re: LOCK TABLE Permissions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: LOCK TABLE Permissions
Date
Msg-id 8307.1374251582@sss.pgh.pa.us
Whole thread Raw
In response to LOCK TABLE Permissions  (Stephen Frost <sfrost@snowman.net>)
Responses Re: LOCK TABLE Permissions
Re: LOCK TABLE Permissions
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:

>     if (lockmode == AccessShareLock)
>         aclresult = pg_class_aclcheck(reloid, GetUserId(),
>                                       ACL_SELECT);
> +   else if (lockmode == RowExclusiveLock)
> +       aclresult = pg_class_aclcheck(reloid, GetUserId(),
> +                        ACL_INSERT | ACL_UPDATE | ACL_DELETE | ACL_TRUNCATE);
>     else
>         aclresult = pg_class_aclcheck(reloid, GetUserId(),
>                                       ACL_UPDATE | ACL_DELETE | ACL_TRUNCATE);

Perhaps it would be better to refactor with a local variable for the
aclmask and just one instance of the pg_class_aclcheck call.  Also, I'm
pretty sure that the documentation work needed is more extensive
than the actual patch ;-).  Otherwise, I don't see a problem with this.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: getting rid of SnapshotNow
Next
From: Jeff Janes
Date:
Subject: Re: AGG_PLAIN thinks sorts are free