Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path
Date
Msg-id 828188.1760392777@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path  (Bryan Green <dbryan.green@gmail.com>)
List pgsql-hackers
Tree view 
Bryan Green <dbryan.green@gmail.com> writes:
> The problem:
> - FRONTEND path: fprintf(stderr, fmt, ap) - incorrect
> - non-FRONTEND path: write_stderr(fmt, ap) - also incorrect

> The first patch only addressed the fprintf issue.  The v2 patch 
> addresses both.

Actually, you'd managed to drop the fprintf->vfprintf change :-(.
I fixed that, pgindent'd it, wordsmithed the commit message,
and pushed.  Many thanks for finding this!

            regards, tom lane

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Fixed a typo in comment in compress_lz4.c
Next
From: Tom Lane
Date:
Subject: Re: Fixed a typo in comment in compress_lz4.c