Re: Keywords in pg_hba.conf should be field-specific - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Keywords in pg_hba.conf should be field-specific
Date
Msg-id 8221.1287325150@sss.pgh.pa.us
Whole thread Raw
In response to Re: Keywords in pg_hba.conf should be field-specific  (Brendan Jurd <direvus@gmail.com>)
Responses Re: Keywords in pg_hba.conf should be field-specific  (Brendan Jurd <direvus@gmail.com>)
List pgsql-hackers
Brendan Jurd <direvus@gmail.com> writes:
> On 17 October 2010 09:59, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Good point. �Maybe the correct fix is to remember whether each token was
>> quoted or not, so that keyword detection can be done safely after the
>> initial lexing. �I still think that the current method is impossibly
>> ugly ...

> I'm happy to revise the patch on that basis.  Any suggestions about
> how to communicate the 'quotedness' of each token?  We could make each
> token a struct consisting of the token itself, plus a boolean flag to
> indicate whether it had been quoted.  Does that work for you?

Seems reasonable.  I had the idea of a parallel list of booleans in the
back of my mind, but a list of structs is probably easier to understand,
and to extend further if necessary.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: WIP: extensible enums
Next
From: Andrew Dunstan
Date:
Subject: Re: WIP: extensible enums