Re: xl_heap_header alignment? - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: xl_heap_header alignment?
Date
Msg-id 81971.1598122815@antos
Whole thread Raw
In response to Re: xl_heap_header alignment?  (Antonin Houska <ah@cybertec.at>)
List pgsql-hackers
Antonin Houska <ah@cybertec.at> wrote:

> If the comment tells that t_hoff can be computed (i.e. it's no necessary to
> include it in the structure), I think the comment should tell why it's yet
> included. Maybe something about "historical reasons"? Perhaps we can say that
> the storage used to be free due to padding, and that it's no longer so, but
> it's still "cheap", so it's not worth to teach the REDO functions to compute
> the value.

I've received some more replies to your email as soon as I had replied. I
don't insist on my proposal, just go ahead with your simpler changes.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com



pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: xl_heap_header alignment?
Next
From: "Andrey M. Borodin"
Date:
Subject: Re: [PATCH] Covering SPGiST index