Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"
Date
Msg-id 8176.1574615186@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Mark Dilger <hornschnorter@gmail.com> writes:
> On 11/24/19 8:12 AM, Ranier Vilela wrote:
>> The test "if (zeropadlen > 0)" is redundant and can be salely removed.
>> It has already been tested in the same path.

> I have not tested your patch, but it looks right to me.

Agreed, seems like an oversight in an old patch of mine.  Pushed.

I concur with John's nearby complaint that you're not submitting
diffs in a useful format.  The file paths are weird.  Also, it's
generally proven to be a good idea to send diffs as attachments,
not embedded in-line in the email --- in-line text is far too
prone to get mangled by assorted mail programs.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Possible arithmetic with NULL pointer or test "stack_base_ptr != NULL" is irrelevant.
Next
From: Ranier Vilela
Date:
Subject: RE: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"