Re: [Patch] - Fix for bug #2558, InitDB failed to run - Mailing list pgsql-patches

Sorry, Im not an expert, and I have the same win 2003 server installation
problem, but dont know what to do with the tree .c files downloaded as a
patch, can you please direct me on how to use the patch?
Thanks !



Andrew Dunstan wrote:
>
>
>
> 1. a patch is generated by the program "diff"
> 2. before we do anything, as Tom Lane says, we need verification of the
> problem, preferably in writing from Microsoft.
>
> cheers
>
> andrew
>
>
> dror wrote:
>>
>>   1.
>>       When saying:
>>       "Please submit the changes as patches, instead of the whole files".
>>       Do you mean to send each file seperately? or other issues as well?
>>   2.
>>       The change was test and design for 8.1.14, but as far as I see
>>       it is also true for any other version.
>>       Of course merge is needed in case that the files were changed
>>       since then, however , due to the fact that it is only few rows
>>       it will be easy to do it.
>>   3.
>>       Alvaro wrote:
>>       "it may be useful to lose the redirection only on the
>>        cases where it fails, so we still have reasonable behavior on
>> non-broken
>>        platforms"
>>
>>       Nice idea, but it is really doesn't matter:  on other platform
>>       than win32, the code left unchanged! the fix is only relevant
>>       for win32 on which (as I explained) the MSI installer (if used)
>>       redirect the output by default to a log file.
>>
>> Regards
>> Dror
>> ------------------------------------------------------------------------
>>
>> > Date: Mon, 14 Aug 2006 12:40:25 -0400
>> > From: alvherre@commandprompt.com
>> > To: dror_b@hotmail.com
>> > CC: pgsql-patches@postgresql.org
>> > Subject: Re: [PATCHES] [Patch] - Fix for bug #2558, InitDB failed to
>> run on windows 2003
>> >
>> > dror wrote:
>> >
>> > > There were two options to solve this issue:
>> > >
>> > > Create a new file , grant a write permission for the Postgres user
>> > > and redirect the output to that file. (EnterpriseDB  use this method)
>> > > Canceling the redirection at all.
>> > >
>> > > I choose the second option and omit the redirection in any case that
>> > > it windows machine and the redirection was sent to DEVNULL.
>> > >
>> > > The only files that I changed are: initDB.c, exec.c and pg_ctl.c
>> >
>> > Please submit the changes as patches, instead of the whole files.
>> Also,
>> > please specify which branch do these patches apply -- is this for 8.1,
>> > or for the current development code?  When checked against the 8.1
>> > pg_ctl.c, the file you sent only contains a regression for a bug fix,
>> > and no change related to what you describe above.
>> >
>> > On the other hand, it may be useful to lose the redirection only on the
>> > cases where it fails, so we still have reasonable behavior on
>> non-broken
>> > platforms.  Or maybe there's a better solution.
>> >
>> > --
>> >
>> Alvaro Herrera
>> http://www.CommandPrompt.com/
>> > PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>>
>>
>> ------------------------------------------------------------------------
>> Express yourself instantly with Windows Live Messenger! Windows Live
>> Messenger!
>> <http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=joinmsncom/messenger>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
>                http://archives.postgresql.org
>
>

--
View this message in context:
http://www.nabble.com/-Patch----Fix-for-bug---2558%2C--InitDB-failed-to-run-on-windows-2003-tf2103710.html#a8164273
Sent from the PostgreSQL - patches mailing list archive at Nabble.com.