Re: [PATCH] initdb: do not exit after warn_on_mount_point - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] initdb: do not exit after warn_on_mount_point
Date
Msg-id 813162.1662908002@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] initdb: do not exit after warn_on_mount_point  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sat, Sep 10, 2022 at 07:14:59PM +0000, andrey.arapov@nixaid.com wrote:
>> Have slightly improved the logic so that it does not report an error
>> "directory \"%s\" exists but is not empty"
>> when it is only supposed to warn the user about the mountpoint, without
>> exiting.

> This definitely isn't a typo, as it's really strongly discouraged to use a
> mount point for the data directory.

Absolutely.  I think maybe the problem here is that warn_on_mount_point()
is a pretty bad name for that helper function, as this is not "just a
warning".

            regards, tom lane



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Check SubPlan clause for nonnullable rels/Vars
Next
From: Mark Dilger
Date:
Subject: Re: why can't a table be part of the same publication as its schema