Re: Expanding HOT updates for expression and partial indexes - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Expanding HOT updates for expression and partial indexes
Date
Msg-id 811d6f42e5481935943556b692859aae9146d4c9.camel@j-davis.com
Whole thread Raw
In response to Re: Expanding HOT updates for expression and partial indexes  ("Greg Burd" <greg@burd.me>)
List pgsql-hackers
On Thu, 2026-03-12 at 17:31 -0400, Greg Burd wrote:
> Other than the heap_modify_tuple() calls I don't know of something
> that allows for direct changes but that doesn't matter, 0002 will
> scan and pick up those attributes even if we introduce a new
> modification path in the future (as intended).

Why do extra work in ExecBRUpdateTriggers() to eliminate the false
negative case if we don't rely on it anyway? If we do need to rely on
it in subsequent patches, then we need to be sure, right?

I guess I'm confused about whether 0002 is introducing a new guarantee
or if it's just a convenient place to eliminate one source of false
negatives.

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Andrey Silitskiy
Date:
Subject: Re: Exit walsender before confirming remote flush in logical replication
Next
From: "Jelte Fennema-Nio"
Date:
Subject: Re: Change copyObject() to use typeof_unqual