Re: [PORTS] Re: patch for minor Win32 makefile bug - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PORTS] Re: patch for minor Win32 makefile bug
Date
Msg-id 8088.986410877@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PORTS] Re: patch for minor Win32 makefile bug  (Jason Tishler <Jason.Tishler@dothill.com>)
Responses Re: [PORTS] Re: patch for minor Win32 makefile bug  (Jason Tishler <Jason.Tishler@dothill.com>)
Re: [PORTS] Re: patch for minor Win32 makefile bug  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Jason Tishler <Jason.Tishler@dothill.com> writes:
>     1. I'm not crazy about the name FE_DLLLIBS -- I don't think that it
>        accurately represents its semantics.

Okay.

>        (I presume that you meant
>        that FE_DLLLIBS = -lcygipc -lcrypt; otherwise, I'm not grokking
>        your proposal.)

Right, given that the other two need not be mentioned.  What about
-L/usr/local/lib, did that make any sense to include or not?

> What about leaving DLLLIBS as defined (in Makefile.win) in my patch, but
> also defining BE_DLLLIBS as follows:
>     BE_DLLLIBS = -L$(top_builddir)/src/backend -lpostgres
> Then one can use this definition is in src/pl/plpgsql/src/Makefile as
> follows:
>     DLLLIBS:= $(BE_DLLLIBS) $(DLLLIBS)
> The above would also be used where ever else was necessary (e.g.,
> regress.dll).

> How does this proposal sound?

Works for me.  Given that we'd like to package RC3 tonight, it'd be nice
to get this done ASAP.  Do you have time to work up and test a patch
today, or shall I risk making untested changes myself?

            regards, tom lane

pgsql-patches by date:

Previous
From: Jason Tishler
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Next
From: Jason Tishler
Date:
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug