Re: PATCH: improve sorting in the Data Editor - Mailing list pgadmin-hackers

<p>Hello Sanket,<p><br /><p>The behaviour you described after applying the patch is correct in my opinion.<p>That is a
usefulfeature to append further sorting columns after previous ones - the patch has no intent to remove this feature at
all.<p><br/><p>For example, "ORDER BY employee_name, employee_id" may be quite reasonable.<p>Whereas "ORDER BY
employee_id,employee_name" is *always* meaningless.<p><br /><p>Sure, the user could define that meaningless search
orderhimself manually, but that's his fault.<p>Our duty is to avoid this situation caused by default sort order.<p><br
/><p><br/><p><br /><p>Wednesday, August 5, 2015, 8:20:51 PM, you wrote:<p><br /><div><table border="0" cellpadding="1"
cellspacing="2"><trvalign="top"><td style="background-color: #0000ff;" width="12"><p><span
class="rvts6">></span></td><tdstyle="background-color: #ffffff;" width="1125"><p><span
class="rvts7">Hi,</span><p><br/><p><span class="rvts7">I have reviewed the patch and below is analysis.</span><p><br
/><p><spanclass="rvts7">- Behaviour of sorting in data editor before applying the patch is as below:</span><p><br
/><p><spanclass="rvts7">By default table is sorted by PK/OID in ascending order.</span><p><span class="rvts7">when user
selectany other column to sort the table, that column gets the second priority for sorting the table like i.e.order by
col_pk,col_column1 where col_pk is column having PK and col_column1 is any other ordinary column.</span><p><br
/><p><spanclass="rvts7">- below is the behaviour I have found after applying the patch:</span><p><br /><p><span
class="rvts7">Bydefault table is sorted by PK/OID in ascending order.</span><p><span class="rvts7">When user selects
anyother column default sorting is removed and table is getting sorted by newly selected column.</span><p><span
class="rvts7">Butafter this if user wants to sort the table by PK or any other column it will have the same behaviour
likeit has before applying the patch. i.e. order by col_column1, col_PK where col_column1 and col_PK are same as
explainedabove. It will not sort the table by newly selected column(col_PK) because sorting of older
column(col_column1)is still in effect and has the higher priority.</span><p><br /><p><span class="rvts7">This will also
confusethe user.</span><p><br /><p><span class="rvts7">So according to me current behaviour of sorting of table data in
pgadminis acceptable.</span><p><br /><p><span class="rvts7">Dave, </span><p><span class="rvts7">Do you have any other
thoughtson it?</span><p><br /><p><br /><p><br /><p><span class="rvts7">Regards,</span><p><span class="rvts7">Sanket
Mehta</span><p><spanclass="rvts7">Sr Software engineer</span><p><span class="rvts7">Enterprisedb</span><p><br /><p><br
/><p><spanclass="rvts7">On Mon, Aug 3, 2015 at 11:07 AM, Sanket Mehta <</span><a class="rvts8"
href="mailto:sanket.mehta@enterprisedb.com">sanket.mehta@enterprisedb.com</a><spanclass="rvts7">>
wrote:</span><p><br/><p><span class="rvts7">Sure Ashesh.</span><p><br /><p><br /><p><span
class="rvts7">Regards,</span><p><spanclass="rvts7">Sanket Mehta</span><p><span class="rvts7">Sr Software
engineer</span><p><spanclass="rvts7">Enterprisedb</span><p><br /><p><br /><p><span class="rvts7">On Mon, Aug 3, 2015 at
10:49AM, Ashesh Vashi <</span><a class="rvts8"
href="mailto:ashesh.vashi@enterprisedb.com">ashesh.vashi@enterprisedb.com</a><spanclass="rvts7">>
wrote:</span><p><br/><p><span class="rvts7">Sanket,</span><p><br /><p><span class="rvts7">Can you please review
it?</span><p><br/><p><br /><p><br /><p><span class="rvts9">--</span><p><span class="rvts9">Thanks &
Regards,</span><p><br/><p><span class="rvts9">Ashesh Vashi</span><p><span class="rvts9">EnterpriseDB INDIA: </span><a
class="rvts10"href="http://www.enterprisedb.com">Enterprise PostgreSQL Company</a><p><br /><p><a class="rvts11"
href="http://www.linkedin.com/in/asheshvashi">http://www.linkedin.com/in/asheshvashi</a><p><br/><p><br /><p><span
class="rvts7">OnSun, Aug 2, 2015 at 3:49 PM, J.F. Oster <</span><a class="rvts8"
href="mailto:jinfroster@mail.ru">jinfroster@mail.ru</a><spanclass="rvts7">> wrote:</span><p><span
class="rvts7">Hello,</span><p><br/><p><span class="rvts7">Here is a small improvement about sorting in the Data
editor.</span><p><br/><p><span class="rvts7">Problem:</span><p><span class="rvts7">If a table has a PK or OIDs, it gets
sortedby PK/OID by default.</span><p><span class="rvts7">When a user wants to sort by any other column, he has first to
click</span><p><spanclass="rvts7">"Remove sort" in the context menu, and only then click "Sort</span><p><span
class="rvts7">ascending"(descending)on column of his choice.</span><p><br /><p><span class="rvts7">If he doesn't remove
thedefault sort, he will get no effect and</span><p><span class="rvts7">probably be puzzled for the first time until
guessesthat he makes</span><p><span class="rvts7">  ORDER BY column_pk, column_of_choice</span><p><span
class="rvts7">whichis totally useless.</span><p><span class="rvts7">The need to "Remove sort" each time is
annoying.</span><p><br/><p><span class="rvts7">Solution:</span><p><span class="rvts7">When a user chooses to sort by
somecolumn, we must discard the</span><p><span class="rvts7">default sort order.</span><p><br /><p><span
class="rvts7">Pleasesee the attached patch.</span><p><span class="rvts7">Thanks.</span><p><br /><p><span
class="rvts12">--</span><p><spanclass="rvts12">Best regards,</span><p><span class="rvts12"> J.F.</span><p><br
/><p><spanclass="rvts12">--</span><p><span class="rvts12">Sent via pgadmin-hackers mailing list (</span><a
class="rvts8"href="mailto:pgadmin-hackers@postgresql.org">pgadmin-hackers@postgresql.org</a><span
class="rvts12">)</span><p><spanclass="rvts12">To make changes to your subscription:</span><p><a class="rvts8"
href="http://www.postgresql.org/mailpref/pgadmin-hackers">http://www.postgresql.org/mailpref/pgadmin-hackers</a><p><br
/></td></tr></table></div><p><br/><p><br /><p><br /><p><br /><p><span class="rvts13">-- </span><p><span
class="rvts13">Bestregards,</span><p><span class="rvts13"> J.F.</span>