Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Remove obsolete executor cleanup code - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove obsolete executor cleanup code
Date
Msg-id 802307.1695863316@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Remove obsolete executor cleanup code  (Amit Langote <amitlan@postgresql.org>)
Responses Re: pgsql: Remove obsolete executor cleanup code
List pgsql-committers
Tree view 
Amit Langote <amitlan@postgresql.org> writes:
> After these modifications, the ExecEnd*() routines for ValuesScan,
> NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> commit removes them.

This seems like quite a bad idea.  From a documentation standpoint
alone, it would be far better for these functions to exist but be
empty.

            regards, tom lane

pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: pgsql: Remove obsolete executor cleanup code
Next
From: Amit Langote
Date:
Subject: Re: pgsql: Remove obsolete executor cleanup code