Re: pgsql: Fix default text search parser's ts_headline code forphrase que - Mailing list pgsql-committers

On 2020-04-09 19:19, Tom Lane wrote:
> Fix default text search parser's ts_headline code for phrase queries.
> 
> src/backend/tsearch/wparser_def.c     | 173 
> +++++++++++++++++++---------------
> src/test/regress/expected/tsearch.out |  43 ++++++---
> src/test/regress/sql/tsearch.sql      |  11 +++
> 3 files changed, 141 insertions(+), 86 deletions(-)

Hi,

I get compiler warning/note from gcc 9.3.0 (on debian stretch):

wparser_def.c: In function ‘prsd_headline’:
wparser_def.c:2530:2: warning: ‘pose’ may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  2530 |  mark_fragment(prs, highlightall, bestb, beste);
       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
wparser_def.c:2384:8: note: ‘pose’ was declared here
  2384 |  int   pose,
       |        ^~~~


I am not sure whether it is useful to report warnings/notes (I can see 
that these are not very important).

There is quite a lot of traffic on postgres-lists already; please let me 
know if it's maybe better to only report 'real' errors.

Thanks,

Erik Rijkers