Re: mingw32 floating point diff - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: mingw32 floating point diff
Date
Msg-id 7fa54146-032e-36e3-5027-67d07209f6dd@2ndquadrant.com
Whole thread Raw
In response to Re: mingw32 floating point diff  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: mingw32 floating point diff  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2019-08-23 15:50, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The circle.sql file already has SET extra_float_digits TO 0, and a few
>> other files have other settings with different values.  Are we content
>> to use various numbers until it works in each case, or should we try to
>> use some consistency?
> 
> The one in rules.sql doesn't count here.  Everyplace else seems to be
> using 0, except for the one in geometry.sql, which seems to be perhaps
> unreasonably conservative.  Might be worth researching why it's -3.

I can confirm that SET extra_float_digits TO -1 in circle.sql fixes the
original complaint.

I don't understand this stuff enough to be able to provide a good source
code comment or commit message, so I'd appreciate some help or someone
else to proceed with this change.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: pg11.5: ExecHashJoinNewBatch: glibc detected...double free orcorruption (!prev)
Next
From: Peter Eisentraut
Date:
Subject: pg_upgrade: Error out on too many command-line arguments