On 4/27/23 11:54 AM, Amit Kapila wrote:
> On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> On 4/27/23 5:37 AM, Amit Kapila wrote:
>>> On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
>>> <bertranddrouvot.pg@gmail.com> wrote:
>>>
>>> +When in recovery, the default value of target_lsn is $node->lsn('replay')
>>> +instead. This is needed when the publisher passed to
>>> wait_for_subscription_sync()
>>> +is a standby node.
>>>
>>> I think this will be useful whenever wait_for_catchup has been called
>>> for a standby node (where self is a standby node). I have tried even
>>> by commenting wait_for_subscription_sync in the new test then it fails
>>> for $node_standby->wait_for_catchup('tap_sub');. So instead, how about
>>> a comment like: "When in recovery, the default value of target_lsn is
>>> $node->lsn('replay') instead which ensures that the cascaded standby
>>> has caught up to what has been replayed on the standby."?
>>>
>>
>> I did it that way because wait_for_subscription_sync() was the first case I had
>> to work on but I do agree that your wording better describe the intend of the new
>> code.
>>
>> Changed in V7 attached.
>>
>
> Pushed.
>
Thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
