Fix background writer processing locking in README - Mailing list pgsql-hackers

From Henrik TJ
Subject Fix background writer processing locking in README
Date
Msg-id 7ecd1d06-24ab-ec54-127c-93e4ec691b77@0x48.dk
Whole thread
List pgsql-hackers
Hi

I was reading through src/backend/storage/buffer/README, and the paragraph 
about writing out buffers seems not to have been updated after starting to 
use the share-exclusive lock level, commit 82467f627bd4.

The paragraph in question:

The background writer takes shared content lock on a buffer while writing it
out (and anyone else who flushes buffer contents to disk must do so too).
This ensures that the page image transferred to disk is reasonably consistent.
We might miss a hint-bit update or two but that isn't a problem, for the same
reasons mentioned under buffer access rules.

The attached patch updates this to use shared-exclusive, and removes the 
consistency bit. Arguably the entire paragraph could be removed, as the 
issue is covered earlier in the document, but I tried to keep the doc 
mostly as-is.


   best regards, Henrik
Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Andres Freund
Date:
Subject: Re: Any reason to keep HEAP_HASOID_OLD?