Re: unconstify equivalent for volatile - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: unconstify equivalent for volatile
Date
Msg-id 7c6faae0-8784-7575-a33a-36d60115ab3c@2ndquadrant.com
Whole thread Raw
In response to Re: unconstify equivalent for volatile  (Andres Freund <andres@anarazel.de>)
Responses Re: unconstify equivalent for volatile  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On 2019-02-22 21:31, Andres Freund wrote:
> On 2019-02-22 12:38:35 +0100, Peter Eisentraut wrote:
>> On 2019-02-19 18:02, Andres Freund wrote:
>>> But even if we were to decide we'd want to keep a volatile in SetLatch()
>>> - which I think really would only serve to hide bugs - that'd not mean
>>> it's a good idea to keep it on all the other functions in latch.c.

> Right. But we should ever look/write into the contents of a latch
> outside of latch.c, so I don't think that'd really be a problem, even if
> we relied on volatiles.

So how about this patch?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Protect syscache from bloating with negative cache entries
Next
From: Peter Eisentraut
Date:
Subject: Re: some ri_triggers.c cleanup