Re: Enable -Wstrict-prototypes and -Wold-style-definition by default - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Date
Msg-id 7bf60ab1-2b5d-4a77-93ce-815072a0a014@eisentraut.org
Whole thread Raw
In response to Re: Enable -Wstrict-prototypes and -Wold-style-definition by default  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
List pgsql-hackers
On 27.03.26 11:07, Bertrand Drouvot wrote:
> That looks ok but I wonder if we should also add '-Werror=vla' to it (
> and remove it from common_warning_flags) to be in sync with what configure.ac
> is doing:
> 
> "
>    PGAC_PROG_CC_CFLAGS_OPT([-Werror=vla])
>    # -Wvla is not applicable for C++
> "

Hmm.  This comment is not actually fully correct.  With g++, you can 
write a VLA and it will work, and also -Wvla will warn about it.  So we 
should actually add that option to C++ as well.  (It is true that VLAs 
are not in standard C++, and g++ with -pedantic will also warn about it.)




pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: Beautify read stream "per buffer data" APIs
Next
From: Peter Eisentraut
Date:
Subject: Re: Define DatumGetInt8 function.