Re: Panic during xlog building with big values - Mailing list pgsql-hackers

From Maksim.Melnikov
Subject Re: Panic during xlog building with big values
Date
Msg-id 7bea0bc6-c5f3-4e6b-8258-2fd5e9fa154e@postgrespro.ru
Whole thread Raw
In response to Panic during xlog building with big values  ("Maksim.Melnikov" <m.melnikov@postgrespro.ru>)
List pgsql-hackers
Hi, Andy, thanks for your review!

I've checked RecordTransactionCommit too, but I don't think it can fire 
similar error. Problem, that was described above, occurred because we 
used external column storage without compression and with REPLICA 
IDENTITY FULL.
To be honest, it's degenerate case, that can occur only in case of tuple 
update/delete, when we need full row to identify updated/deleted value, 
more info can be found in doc [1].

I've fixed comments with yours remarks, thanks. Patch is attached.

Also rebased patch with commit d3ba50db48e66be8804b9edf093b0f921d625425.

[1] 
https://www.postgresql.org/docs/current/logical-replication-publication.html

Best regards,
Maksim Melnikov

Attachment

pgsql-hackers by date:

Previous
From: Arseniy Mukhin
Date:
Subject: Re: Improved TAP tests by replacing sub-optimal uses of ok() with better Test::More functions
Next
From: jian he
Date:
Subject: Re: add function argument name to substring and substr