Re: [PATCH] Add error handling to byteaout. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Add error handling to byteaout.
Date
Msg-id 7B69E6BD-D9D6-4234-B8BA-ADEF99111AE1@anarazel.de
Whole thread Raw
In response to Re: [PATCH] Add error handling to byteaout.  (Andreas Seltenreich <andreas.seltenreich@credativ.de>)
List pgsql-hackers
On June 3, 2015 9:42:21 PM GMT+02:00, Andreas Seltenreich <andreas.seltenreich@credativ.de> wrote:
>Piotr Stefaniak writes:
>>>> s/int/Size/ doesn't fix anything on 32-bit machines.
>>
>> Postgres requires twos-complement representation, so that the
>> assumption that signed integer types wrap around on overflow can be
>> safely made.

Uh, no. The C standard defines signed overflow as undefined, an compilers assume it doesn't happen. The optimize based
ony observation.
 


--- 
Please excuse brevity and formatting - I am writing this on my mobile phone.



pgsql-hackers by date:

Previous
From: Andreas Seltenreich
Date:
Subject: Re: [PATCH] Add error handling to byteaout.
Next
From: Andrew Dunstan
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file