Re: pgwin32_safestat weirdness - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgwin32_safestat weirdness
Date
Msg-id 7995.1208357582@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgwin32_safestat weirdness  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Andrew Dunstan wrote:
>> I think a simple approach is all we need for now - not even sure we
>> need an ifeq() section in the makefile.
>> 
>> Here's a patch, which I'll apply unless there's an objection.

> Seems a reasonable step for now, yeah - we can add BUILDING_LIBPQ
> sometime in the future if we need it.

+1 from here too, modulo this:

> However, you patch needs to set the define in the MSVC build as well,
> to make sure that the produced libpq.dll is equivalent in functionality.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_terminate_backend() issues
Next
From: Gregory Stark
Date:
Subject: Re: pg_terminate_backend() issues