On 15.10.25 17:58, Srirama Kucherlapati wrote:
> Hi Andres and team,
>
> Please find attached the patch addressing Meson build changes for AIX.
>
> We tried to build using below meson
>
> ## meson -v
>
> 1.6.1
>
> For the following files, the shared_module() function requires
> specifying the
>
> appropriate symbol import file, which is provided via the aix_link_args
>
> variable:
>
> src/backend/jit/llvm/meson.build
>
> src/backend/replication/libpqwalreceiver/meson.build
>
> src/backend/replication/pgoutput/meson.build
>
> src/backend/snowball/meson.build
>
> src/backend/utils/mb/conversion_procs/meson.build
>
> Additionally, with the latest version of Meson, when building static
> libraries,
>
> the library file name must be suffixed with “_static” in the following
> files:
>
> src/interfaces/ecpg/compatlib/meson.build
>
> src/interfaces/ecpg/ecpglib/meson.build
>
> src/interfaces/ecpg/pgtypeslib/meson.build
>
> src/interfaces/libpq/meson.build
It is not going to be acceptable to sprinkle this much AIX-specific code
around. Those changes to the meson.build files were not needed before
AIX support was removed. You should find a way to do it without these
changes.
The changes in src/include/port/aix.h in your patch don't make sense.
This indicates that you are doing something wrong in your local builds.
Please fix that.