Re: [PATCH] rename column if exists - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] rename column if exists
Date
Msg-id 79423E73-C567-403C-A30F-1A9695BBB8F6@yesql.se
Whole thread Raw
In response to Re: [PATCH] rename column if exists  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: [PATCH] rename column if exists
List pgsql-hackers
> On 4 Nov 2021, at 14:26, David G. Johnston <david.g.johnston@gmail.com> wrote:
>
> On Thursday, November 4, 2021, Daniel Gustafsson <daniel@yesql.se <mailto:daniel@yesql.se>> wrote:
> > On 22 Mar 2021, at 20:40, David Oksman <oksman.dav@gmail.com <mailto:oksman.dav@gmail.com>> wrote:
> >
> > Added the ability to specify IF EXISTS when renaming a column of an object (table, view, etc.).
> > For example: ALTER TABLE distributors RENAME COLUMN IF EXISTS address TO city;
> > If the column does not exist, a notice is issued instead of throwing an error.
>
> What is the intended use-case for RENAME COLUMN IF EXISTS?  I'm struggling to
> see when that would be helpful to users but I might not be imaginative enough.
>
> Same reasoning as for all the other if exists we have, idempotence. Being able to run the command on an object that
isalready in the desired state without provoking an error. 

If the object is known to be in the desired state, there is no need to use IF
EXISTS.  Personally I think IF EXISTS commands are useful when they provide a
transition to a known end state, but in this case it's an unknown end state.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion