Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Date
Msg-id 79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de
Whole thread Raw
In response to Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Hi,

On November 26, 2021 5:53:31 PM PST, Andres Freund <andres@anarazel.de> wrote:
>Hi,
>
>On November 26, 2021 7:24:15 AM PST, Robert Haas <robertmhaas@gmail.com> wrote:
>>Fortunately, it seems to have been only a minor oversight.
>
Agreed.

I wonder if we should turn some of these ifdefs into something boiling down to if (0) { ifdef body}... No need to make
itimpossible for the compiler to help us in most of these cases... 

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.



pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Harden be-gssapi-common.h for headerscheck
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Update high level vacuumlazy.c comments.