Re: pgsql: Fix for globals.c- c.h must come first - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix for globals.c- c.h must come first
Date
Msg-id 7842.1529436064@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix for globals.c- c.h must come first  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Are there arguments for doing this in postgres.h rather than c.h?

No, c.h is the correct place.  The core problem is that we have to include
pg_config.h before <stdio.h> et al in order to have consistent libc APIs
(on platforms where this matters), and c.h is what does that.

> I think we shouldn't do this for v11, as it seems likely that some
> extensions would be broken. While not hard to fix, that seems
> unnecessary after beta1? Seems unlikely we'll introduce further cases
> before new features are merged.

Yeah, waiting for v12 seems fine.

            regards, tom lane


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Fix for globals.c- c.h must come first
Next
From: Bruce Momjian
Date:
Subject: pgsql: README: add URLs for openldap installation