Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros)
Date
Msg-id 7840.1570478850@sss.pgh.pa.us
Whole thread Raw
In response to Re: expressive test macros (was: Report test_atomic_ops() failuresconsistently, via macros)  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-10-07 19:57, Tom Lane wrote:
>> I'd just put them all in c.h.  I see no reason why a new header
>> is helpful.

> Assert stuff is already in there, but surely stuff that calls elog()
> doesn't belong in there?

True, though I had the impression that Andres wanted to propose things
that would work in either frontend or backend, presumably with different
implementations.  You could argue it either way as to whether to have
that in c.h (with an #ifdef) or separately in postgres.h and
postgres_fe.h.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: expressive test macros (was: Report test_atomic_ops() failuresconsistently, via macros)
Next
From: Andres Freund
Date:
Subject: Re: expressive test macros (was: Report test_atomic_ops() failuresconsistently, via macros)