Re: Fwd: Bug#372115: Last security update of postgresql-contrib breaks database replication with DBMirror.pl - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Fwd: Bug#372115: Last security update of postgresql-contrib breaks database replication with DBMirror.pl
Date
Msg-id 780.1149957500@sss.pgh.pa.us
Whole thread Raw
In response to Fwd: Bug#372115: Last security update of postgresql-contrib breaks database replication with DBMirror.pl  (Martin Pitt <martin@piware.de>)
List pgsql-bugs
Martin Pitt <martin@piware.de> writes:
> Does anyone know DBMirror.pl? The proposed fix seems wrong since it
> just reverts the behavior to the old quote escaping style.

I don't know it, but the function being complained of seems exactly the
sort of ad-hoc escaping logic that the security update warns you should
get rid of.  (I fear we failed to notice it because it was in Perl not C
:-() I think it should be rewritten from the ground up.  Does the Pg
Perl module expose PQescapeString by any chance?  Relying on that would
be far better than letting this code live.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Fwd: Bug#372115: Last security update of postgresql-contrib
Next
From: "Rojas, Fernando \(CIAT\)"
Date:
Subject: Error Starting Back END