> On 28 Nov 2024, at 07:34, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Oct 22, 2024 at 09:49:10AM +0900, Michael Paquier wrote:
>> Note that there were a couple of value checks not part of the queries
>> that relied on values from the catalogs for some relpersistences and
>> replidents. I've fixed them while on it.
>>
>> Thoughts or comments are welcome.
>
> So, this one has been sitting in the CF for a couple of weeks now.
> I've looked at it again and the queries are written the same. There
> was one inconsistency with the ordering of the headers and one
> indentation issue with a query for extended stats.
>
> Any objections against applying it? This is the last area of the code
> where we rely on such hardcoded values rather than CppAsString2().
> Note also the pg_am.h inclusion which is incorrect.
LGTM, I didn't scan for omissions but the ones in the patch look right to me.
I sort of wish we had a shorter macro as CppAsString2() get's pretty verbose
when used frequently like this.
--
Daniel Gustafsson
